update original

Author: funkill

rust-cookbook/CONTRIBUTING.md

@@ -271,9 +271,7 @@ Mark examples that depend on external systems with `no_run` or remove them
 if they are not required for the example.  Avoid inline comments, preferring
 explanation in the description.
 
-> ```rust
-> extern crate rand;
->
+> ```rust,edition2018
 > use rand::distributions::{Normal, Distribution};
 >
 > fn main() {

rust-cookbook/Cargo.toml

@@ -15,12 +15,12 @@ bitflags = "1.0"
 byteorder = "1.0"
 cc = "1.0"
 chrono = "0.4"
-clap = "2.29"
+clap = "4.5"
 crossbeam = "0.5"
 crossbeam-channel = "0.3.9"
 csv = "1.0"
 data-encoding = "2.1.0"
-env_logger = "0.5"
+env_logger = "0.11.3"
 error-chain = "0.12"
 flate2 = "1.0"
 glob = "0.3"

rust-cookbook/README.md

@@ -19,7 +19,7 @@ If you'd like to read it locally:
 ```bash
 $ git clone https://github.com/rust-lang-nursery/rust-cookbook
 $ cd rust-cookbook
-$ cargo install mdbook --vers "0.4.5"
+$ cargo install mdbook --vers "0.4.43"
 $ mdbook serve --open
 ```
 

rust-cookbook/build.rs

@@ -1,6 +1,3 @@
-extern crate skeptic;
-extern crate walkdir;
-
 use walkdir::WalkDir;
 
 const REMOVED_TESTS: &[&str] = &[

rust-cookbook/ci/install_deps.sh

@@ -18,7 +18,7 @@ if [[ "${CONTENT_TESTS:-}" == 1 ]]; then
         pyenv local 3.6.0
         pip3 install --user link-checker==0.1.0
     fi
-    cargo install mdbook --vers '0.4.5' --debug
+    cargo install mdbook --vers '0.4.43' --debug
 fi
 
 exit 0

rust-cookbook/src/cli/arguments/clap-basic.md

@@ -6,39 +6,52 @@ This application describes the structure of its command-line interface using
 `clap`'s builder style. The [documentation] gives two other possible ways to
 instantiate an application.
 
-In the builder style, `with_name` is the unique identifier that `value_of` will
-use to retrieve the value passed. The `short` and `long` options control the
+In the builder style, each possible argument is described by an `Arg`
+struct. The string given to `Arg::new()` is the internal
+name of the argument. The `short` and `long` options control the
 flag the user will be expected to type; short flags look like `-f` and long
 flags look like `--file`.
 
+The `get_one()` method is used to get an argument's value.
+It returns `Some(&`value`)` if the argument was supplied by
+the user, else `None`.
+
+The use of `PathBuf` is to allow file paths which are legal
+in Linux and MacOS, but not in Rust UTF-8 strings. This is
+best practice: one encounters such paths quite rarely in
+practice, but when it happens it is really frustrating
+without this.
+
 ```rust,edition2018
-use clap::{Arg, App};
+use std::path::PathBuf;
+
+use clap::{Arg, Command, builder::PathBufValueParser};
 
 fn main() {
-    let matches = App::new("My Test Program")
+    let matches = Command::new("My Test Program")
         .version("0.1.0")
-        .author("Hackerman Jones <[email protected]>")
         .about("Teaches argument parsing")
-        .arg(Arg::with_name("file")
-                 .short("f")
+        .arg(Arg::new("file")
+                 .short('f')
                  .long("file")
-                 .takes_value(true)
-                 .help("A cool file"))
-        .arg(Arg::with_name("num")
-                 .short("n")
+                 .help("A cool file")
+                 .value_parser(PathBufValueParser::default()))
+        .arg(Arg::new("num")
+                 .short('n')
                  .long("number")
-                 .takes_value(true)
                  .help("Five less than your favorite number"))
         .get_matches();
 
-    let myfile = matches.value_of("file").unwrap_or("input.txt");
-    println!("The file passed is: {}", myfile);
+    let default_file = PathBuf::from("input.txt");
+    let myfile: &PathBuf = matches.get_one("file").unwrap_or(&default_file);
+    println!("The file passed is: {}", myfile.display());
 
-    let num_str = matches.value_of("num");
+    let num_str: Option<&String> = matches.get_one("num");
     match num_str {
         None => println!("No idea what your favorite number is."),
         Some(s) => {
-            match s.parse::<i32>() {
+            let parsed: Result<i32, _> = s.parse();
+            match parsed {
                 Ok(n) => println!("Your favorite number must be {}.", n + 5),
                 Err(_) => println!("That's not a number! {}", s),
             }
@@ -47,24 +60,19 @@ fn main() {
 }
 ```
 
-Usage information is generated by `clap`. The usage for the example application
-looks like this.
+Usage information is generated by `clap -h`. The usage for
+the example application looks like this.
 
 ```
-My Test Program 0.1.0
-Hackerman Jones <[email protected]>
 Teaches argument parsing
 
-USAGE:
-    testing [OPTIONS]
-
-FLAGS:
-    -h, --help       Prints help information
-    -V, --version    Prints version information
+Usage: clap-cookbook [OPTIONS]
 
-OPTIONS:
-    -f, --file <file>     A cool file
-    -n, --number <num>    Five less than your favorite number
+Options:
+  -f, --file <file>   A cool file
+  -n, --number <num>  Five less than your favorite number
+  -h, --help          Print help
+  -V, --version       Print version
 ```
 
 We can test the application by running a command like the following.

rust-cookbook/src/concurrency/parallel/rayon-parallel-sort.md

@@ -19,7 +19,7 @@ fn main() {
   let mut vec = vec![String::new(); 100_000];
   vec.par_iter_mut().for_each(|p| {
     let mut rng = thread_rng();
-    *p = (0..5).map(|_| rng.sample(&Alphanumeric)).collect()
+    *p = (0..5).map(|_| rng.sample(&Alphanumeric) as char).collect()
   });
   vec.par_sort_unstable();
 }

rust-cookbook/src/concurrency/thread/crossbeam-complex.md

@@ -24,10 +24,7 @@ to prevent the entire program from blocking on the worker for-loops. You can
 think of the calls to `drop` as signaling that no more messages will be sent.
 
 
-```rust
-extern crate crossbeam;
-extern crate crossbeam_channel;
-
+```rust,edition2018
 use std::thread;
 use std::time::Duration;
 use crossbeam_channel::bounded;

rust-cookbook/src/concurrency/thread/crossbeam-spsc.md

@@ -33,7 +33,7 @@ fn main() {
 ```
 
 [crossbeam-channel]: https://docs.rs/crate/crossbeam-channel/
-[ex-crossbeam-spawn]: concurrency/threads.html#spawn-a-short-lived-thread
+[ex-crossbeam-spawn]: #spawn-a-short-lived-thread
 [`crossbeam::scope`]: https://docs.rs/crossbeam/*/crossbeam/fn.scope.html
 [`Scope::spawn`]: https://docs.rs/crossbeam/*/crossbeam/thread/struct.Scope.html#method.spawn
 [`crossbeam_channel::unbounded`]: https://docs.rs/crossbeam-channel/*/crossbeam_channel/fn.unbounded.html

rust-cookbook/src/concurrency/thread/threadpool-fractal.md

@@ -27,6 +27,7 @@ use image::{ImageBuffer, Pixel, Rgb};
 #     foreign_links {
 #         MpscRecv(RecvError);
 #         Io(std::io::Error);
+#         Image(image::ImageError);
 #     }
 # }
 #