`p_offset` used as a memory offset for Fuchsia

[Zoxc]

In src/print/fuchsia.rs, Phdr::notes computes the in-memory note address as base + p_offset, but ELF Elf_Phdr.p_offset is a file offset.

[programmerjake]

the code actually looks correct to me, base presumably points to the memory-mapped ELF file so using the file-offset to offset from base would give the correct pointer. That said, someone with Fuchsia libc experience should double check.

[philipc]

I don't know anything about Fuchsia, but base comes from dl_phdr_info::addr and on Linux you would need to do dlpi_addr + p_vaddr. Also the same file here uses p_vaddr for a similar calculation in SegmentIter::next.