From b692905bcb067ce2dfe0214d206aba5d3b15d18f Mon Sep 17 00:00:00 2001
From: Tobias Bieniek <tobias@bieniek.cloud>
Date: Fri, 4 Oct 2024 15:30:12 +0200
Subject: [PATCH] models/feature: Add iteration limit warning (#9580)

---
 src/models/feature.rs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/models/feature.rs b/src/models/feature.rs
index 843e0f6e23..99e2ae1ded 100644
--- a/src/models/feature.rs
+++ b/src/models/feature.rs
@@ -22,7 +22,7 @@ pub fn split_features(features: FeaturesMap) -> (FeaturesMap, FeaturesMap) {
 
     // Then, we recursively move features from `features` to `features2` if they
     // depend on features in `features2`.
-    for _ in 0..ITERATION_LIMIT {
+    for i in (0..ITERATION_LIMIT).rev() {
         let split = features
             .into_iter()
             .partition::<FeaturesMap, _>(|(_k, vals)| {
@@ -33,6 +33,10 @@ pub fn split_features(features: FeaturesMap) -> (FeaturesMap, FeaturesMap) {
 
         if !split.1.is_empty() {
             features2.extend(split.1);
+
+            if i == 0 {
+                warn!("Iteration limit reached while splitting features!");
+            }
         } else {
             break;
         }