Fix ICE while computing type layout#14837
Merged
Jarcho merged 1 commit intorust-lang:masterfrom May 19, 2025
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Jarcho
added
the
beta-nominated
Contributor
|
Looks like the The test case can be simplified to: trait Trait { type T; }
struct S<T: Trait>(T::T);
type Map<T> = HashMap<u32, *const S<T>>;The Can you add a comment roughly explaining what actually causes the |
If a type is incomplete, for example if generic parameters are not available yet, although they are not escaping, its layout may not be computable. Calling `TyCtxt::layout_of()` would create a delayed bug in the compiler.
samueltardieu
force-pushed
the
issue-14822
branch
from
8b493cf to
72a4e33
Compare
Member
Author
I have reused your explanation as-is, and the simplified test case. |
Member
|
The commit introducing this ICE #14717 isn't in beta yet and will get into beta together with this fix. No backport required. |
flip1995
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a type is incomplete, for example if generic parameters are not available yet, although they are not escaping, its layout may not be computable. Calling
TyCtxt::layout_of()would create a delayed bug in the compiler.changelog: [
zero_sized_map_values]: fix ICEFixes #14822
r? @Jarcho