Auto merge of #151145 - GuillaumeGomez:reduce-rustdoc-flakyness, r=jieyouxu

Reduce rustdoc GUI flakyness, take 2

Fixes #151006 (hopefully).

Seems like #151053 did not fix the flakyness issue, so here is another take on this issue.

r? @jieyouxu

Author: bors

tests/rustdoc-gui/utils.goml

@@ -29,19 +29,37 @@ define-function: (
     "open-settings-menu",
     [],
     block {
-        call-function: ("click-settings-button", {})
-        // Wait for the popover to appear...
-        wait-for-css: ("#settings", {"display": "block"})
+        store-count: ("#settings", nb_settings_menu)
+        if: (|nb_settings_menu| != 0, block {
+            store-css: ("#settings", {"display": settings_display})
+        })
+        else: block {
+            store-value: (settings_display, "none")
+        }
+        if: (|settings_display| != "block", block {
+            call-function: ("click-settings-button", {})
+            // Wait for the popover to appear...
+            wait-for-css: ("#settings", {"display": "block"})
+        })
     }
 )
 
 define-function: (
     "close-settings-menu",
     [],
     block {
-        call-function: ("click-settings-button", {})
-        // Wait for the popover to disappear...
-        wait-for-css-false: ("#settings", {"display": "block"})
+        store-count: ("#settings", nb_settings_menu)
+        if: (|nb_settings_menu| != 0, block {
+            store-css: ("#settings", {"display": settings_display})
+        })
+        else: block {
+            store-value: (settings_display, "block")
+        }
+        if: (|settings_display| == "block", block {
+            call-function: ("click-settings-button", {})
+            // Wait for the popover to disappear...
+            wait-for-css-false: ("#settings", {"display": "block"})
+        })
     }
 )