-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Closed
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Description
library/std/Cargo.toml contains:
addr2line = { version = "0.16.0", optional = true, default-features = false }
miniz_oxide = { version = "0.4.0", optional = true, default-features = false }
library/backtrace/Cargo.toml has:
addr2line = { version = "0.17.0", default-features = false }
miniz_oxide = { version = "0.5.0", default-features = false }
(and current master of the backtrace-rs repo has even different versions)
It seems to me backtrace should have its own rustc-dep-of-std feature, which would avoid libstd enabling the feature on stale dependencies.
It's worth noting that the dependencies in crates/as-if-std/Cargo.toml in backtrace-rs match what's currently in libstd, although I'm not sure what that's testing considering there is no dependency on the backtrace crate in there...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.