Merged
Conversation
There might be more type params than args to a method call, which leads to an index out of bounds panic.
These are already slices, no need to slice them again
Use id-based thread parking on SOLID By using the [`slp_tsk`/`wup_tsk`](https://cs.uwaterloo.ca/~brecht/courses/702/Possible-Readings/embedded/uITRON-4.0-specification.pdf) system functions instead of an event-flag structure, `Parker` becomes cheaper to construct and SOLID can share the implementation used by NetBSD and SGX. ping ``@kawadakk`` r? ``@m-ou-se`` ``@rustbot`` label +T-libs
…iler-errors Fix index out of bounds ICE in `point_at_expr_source_of_inferred_type` There might be more type params than args to a method call, which leads to an index out of bounds panic. I'm not familiar with this code at all, so unsure whether this is the right fix, but at least this patch fixes rust-lang#108042 for me (I hit the same issue with similar code)
…lnay Constify `RangeBounds`, `RangeX::contains` and `RangeX::is_empty` (where applicable). cc `@fee1-dead` `@rustbot` label +T-libs-api -T-libs Tracking issue: rust-lang#108082
…er-errors don't clone types that are copy
simplify some refs
be nice and don't slice These are already slices, no need to slice them again
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 639377ed73 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 16, 2023
Collaborator
|
Finished benchmarking commit (4b34c7b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
point_at_expr_source_of_inferred_type#108050 (Fix index out of bounds ICE inpoint_at_expr_source_of_inferred_type)RangeBounds,RangeX::containsandRangeX::is_empty(where applicable). #108084 (ConstifyRangeBounds,RangeX::containsandRangeX::is_empty(where applicable).)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup