rustdoc: fix missing resource suffix on crates.js#129641
rustdoc: fix missing resource suffix on crates.js#129641bors merged 1 commit intorust-lang:masterfrom
crates.js#129641Conversation
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
Fixes a regression introduced in rust-lang#128252.
notriddle
force-pushed
the
notriddle/missing-crates-js-resource-suffix
branch
from
ec7e313 to
a1746b4
Compare
|
Could you add a test to ensure the suffix is present in |
There was a problem hiding this comment.
Suggestion: since this is a rustdoc-specific test, could we prefix this test name with rustdoc- or something?
There was a problem hiding this comment.
(Context: there is a emit-to-stdout that we're porting in the neighbor PR #128460 which is exercising rustc only, which I am suggesting to rename to rustc-emit-to-stdout to make it less confusing)
How is what you’re adding for different from the test that’s already there? |
|
Well apparently it's not working since it didn't catch this regression, so seems like either this test is incomplete or testing things incorrectly. |
|
Yes, I know. I updated the test in this PR. |
Ah indeed, missed it. Well done, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#129421 (add repr to the allowlist for naked functions) - rust-lang#129480 (docs: correct panic conditions for rem_euclid and similar functions) - rust-lang#129551 (ub_checks intrinsics: fall back to cfg(ub_checks)) - rust-lang#129608 (const-eval: do not make UbChecks behavior depend on current crate's flags) - rust-lang#129613 (interpret: do not make const-eval query result depend on tcx.sess) - rust-lang#129641 (rustdoc: fix missing resource suffix on `crates.js`) - rust-lang#129657 (Rename `BikeshedIntrinsicFrom` to `TransmuteFrom`) - rust-lang#129666 (interpret: add missing alignment check in raw_eq) - rust-lang#129667 (Rustc driver cleanup) - rust-lang#129668 (Fix Pin::set bounds regression) - rust-lang#129686 (coverage: Rename `CodeRegion` to `SourceRegion`) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#129421 (add repr to the allowlist for naked functions) - rust-lang#129480 (docs: correct panic conditions for rem_euclid and similar functions) - rust-lang#129551 (ub_checks intrinsics: fall back to cfg(ub_checks)) - rust-lang#129608 (const-eval: do not make UbChecks behavior depend on current crate's flags) - rust-lang#129613 (interpret: do not make const-eval query result depend on tcx.sess) - rust-lang#129641 (rustdoc: fix missing resource suffix on `crates.js`) - rust-lang#129657 (Rename `BikeshedIntrinsicFrom` to `TransmuteFrom`) - rust-lang#129666 (interpret: add missing alignment check in raw_eq) - rust-lang#129667 (Rustc driver cleanup) - rust-lang#129668 (Fix Pin::set bounds regression) - rust-lang#129686 (coverage: Rename `CodeRegion` to `SourceRegion`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#129641 - notriddle:notriddle/missing-crates-js-resource-suffix, r=GuillaumeGomez rustdoc: fix missing resource suffix on `crates.js` Fixes a regression introduced in rust-lang#128252.
6 participants
Fixes a regression introduced in #128252.