Stablize anonymous pipe by NobodyXu · Pull Request #137793 · rust-lang/rust

NobodyXu · 2025-02-28T13:56:21Z

Since #135822 is staled, I create this PR to stablise anonymous pipe

try-job: test-various

rustbot · 2025-02-28T13:56:28Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The Miri subtree was changed

cc @rust-lang/miri

jieyouxu · 2025-02-28T13:58:24Z

Rolling the original libs reviewer for the other stabilization attempt.
r? @joboet

tests/run-make/broken-pipe-no-ice/rmake.rs

oli-obk · 2025-02-28T14:22:04Z

Please squash the commits

rustbot · 2025-02-28T14:37:08Z

Some changes occurred in src/tools/cargo

cc @ehuss

jieyouxu · 2025-02-28T14:46:14Z

(Some unintentional submodule changes I think)

NobodyXu · 2025-03-01T01:04:59Z

The CI error is not related to any changes in this PR:

tidy error: could not find exception package `foldhash`

tgross35 · 2025-03-01T02:30:48Z

#135822 also did some refactoring, are you also planning to put that up? If you do it in a separate PR feel free to request a review from me and we can probably merge it pretty quick.

NobodyXu · 2025-03-01T02:34:32Z

If you do it in a separate PR feel free to request a review from me and we can probably merge it pretty quick.

Yes I want to put it in separate PR, I hope this PR can merge quick and hope that debian could pick it up, so that jobserver/etc can use it to reduce their burden

NobodyXu · 2025-03-01T13:36:05Z

Reverted submodules changes, and tidy passed locally, so CI should be fixed now

NobodyXu · 2025-03-01T20:32:09Z

cc @joboet this pr is ready for review

joshtriplett · 2025-03-03T08:53:05Z

LGTM

NobodyXu · 2025-03-04T13:22:52Z

Can we get this PR merged please?

joboet

I still have the same request as in the original PR:

The changes here look good to me, though I'd like to see another change before stabilization:

Currently, things like the Stdio: From<PipeWriter> implementations live in sys:: which IMHO is really confusing and dangerous (because people will forget to add these implementations when porting std). Could you move all the public trait implementations to io::pipe (and os::_::pipe for the platform-specific implementations)?

tgross35 · 2025-03-13T18:52:19Z

@bors try

…<try> Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various

bors · 2025-03-13T18:53:32Z

⌛ Trying commit 6863a99 with merge 639d746...

bors · 2025-03-13T20:15:35Z

☀️ Try build successful - checks-actions
Build commit: 639d746 (639d746f06b58f56711e3376dfa3e63104df8fc8)

NobodyXu · 2025-03-14T06:34:57Z

@rustbot ready

joboet · 2025-03-17T08:49:41Z

@bors r=@joshtriplett

bors · 2025-03-17T08:49:44Z

📌 Commit 6863a99 has been approved by joshtriplett

It is now in the queue for this repository.

Rollup of 9 pull requests Successful merges: - rust-lang#136355 (Add `*_value` methods to proc_macro lib) - rust-lang#137621 (Add std support to cygwin target) - rust-lang#137793 (Stablize anonymous pipe) - rust-lang#138341 (std: Mention clone-on-write mutation in Arc<T>) - rust-lang#138517 (Improve upvar analysis for deref of child capture) - rust-lang#138584 (Update Rust Foundation links in Readme) - rust-lang#138586 (Document `#![register_tool]`) - rust-lang#138590 (Flatten and simplify some control flow 🫓) - rust-lang#138592 (update change entry for rust-lang#137147) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137793 - NobodyXu:stablise-annoymous-pipe, r=joshtriplett Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various

jhpratt · 2025-03-18T03:52:57Z

still in the queue after being merged

@bors r-

PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account.

…Poison,saethlin Trusty: Fix build for anonymous pipes and std::sys::process PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account. cc `@randomPoison`

Rollup merge of rust-lang#138875 - thaliaarchi:trusty-build, r=randomPoison,saethlin Trusty: Fix build for anonymous pipes and std::sys::process PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account. cc `@randomPoison`

…r=joshtriplett Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various

PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account.

…Poison,saethlin Trusty: Fix build for anonymous pipes and std::sys::process PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account. cc `@randomPoison`

rustbot assigned ibraheemdev Feb 28, 2025

This comment was marked as resolved.

Sign in to view

rustbot assigned joboet and unassigned ibraheemdev Feb 28, 2025

jieyouxu reviewed Feb 28, 2025

View reviewed changes

tests/run-make/broken-pipe-no-ice/rmake.rs Outdated Show resolved Hide resolved

NobodyXu force-pushed the stablise-annoymous-pipe branch from 791a3fd to 57bdbe6 Compare February 28, 2025 14:37

This comment has been minimized.

Sign in to view

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2025

NobodyXu changed the title ~~Stablise anonymous pipe~~ Stablize anonymous pipe Mar 1, 2025

NobodyXu force-pushed the stablise-annoymous-pipe branch 2 times, most recently from 8acff46 to 7acb0e3 Compare March 1, 2025 13:35

jieyouxu mentioned this pull request Mar 1, 2025

Prevent run-make test recipes (rmake.rs) from using *any* unstable features #137532

Closed

6 tasks

joboet requested changes Mar 5, 2025

View reviewed changes

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2025

jhpratt mentioned this pull request Mar 17, 2025

Rollup of 9 pull requests #138595

Merged

bors merged commit 62c2a7b into rust-lang:master Mar 17, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 17, 2025

tbu- mentioned this pull request Mar 17, 2025

Stabilize anonymous_pipe #135822

Closed

jhpratt mentioned this pull request Mar 18, 2025

Rollup of 12 pull requests #138636

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2025

NobodyXu deleted the stablise-annoymous-pipe branch March 20, 2025 00:21

thaliaarchi mentioned this pull request Mar 24, 2025

Trusty: Fix build for anonymous pipes and std::sys::process #138875

Merged

seritools mentioned this pull request Dec 30, 2025

Rust9x updates for future Rust versions rust9x/rust#47

Closed

2 tasks

Uh oh!

Conversation

NobodyXu commented Feb 28, 2025 • edited by tgross35 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

rustbot commented Feb 28, 2025

Uh oh!

jieyouxu commented Feb 28, 2025

Uh oh!

Uh oh!

oli-obk commented Feb 28, 2025

Uh oh!

rustbot commented Feb 28, 2025

Uh oh!

jieyouxu commented Feb 28, 2025

Uh oh!

This comment has been minimized.

NobodyXu commented Mar 1, 2025

Uh oh!

tgross35 commented Mar 1, 2025

Uh oh!

NobodyXu commented Mar 1, 2025

Uh oh!

NobodyXu commented Mar 1, 2025

Uh oh!

NobodyXu commented Mar 1, 2025

Uh oh!

joshtriplett commented Mar 3, 2025

Uh oh!

NobodyXu commented Mar 4, 2025

Uh oh!

joboet left a comment

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Mar 13, 2025

Uh oh!

bors commented Mar 13, 2025

Uh oh!

bors commented Mar 13, 2025

Uh oh!

NobodyXu commented Mar 14, 2025

Uh oh!

joboet commented Mar 17, 2025

Uh oh!

bors commented Mar 17, 2025

Uh oh!

Uh oh!

jhpratt commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

NobodyXu commented Feb 28, 2025 •

edited by tgross35

Loading