Implement read_buf for Hermit#138301
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 19, 2025
Merged
Conversation
Collaborator
rustbot
added
O-hermit
This was referenced Mar 10, 2025
mkroening
approved these changes
Mar 10, 2025
Contributor
mkroening
left a comment
mkroening
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! :)
Collaborator
|
☔ The latest upstream changes (presumably #138302) made this pull request unmergeable. Please resolve the merge conflicts. |
thaliaarchi
force-pushed
the
io-optional-methods/hermit
branch
from
a372405 to
19b8643
Compare
tgross35
reviewed
Mar 17, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
The two new unsafe blocks should get SAFETY comments, r=me after that
thaliaarchi
force-pushed
the
io-optional-methods/hermit
branch
from
19b8643 to
c5fc193
Compare
Contributor
Author
|
I've added SAFETY comments. |
tgross35
approved these changes
Mar 18, 2025
Contributor
|
Thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 18, 2025
…rmit, r=tgross35 Implement `read_buf` for Hermit Following hermit-os/kernel#1606, it is now safe to implement `Read::read_buf` for file descriptors on Hermit. cc `@mkroening`
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 18, 2025
…rmit, r=tgross35 Implement `read_buf` for Hermit Following hermit-os/kernel#1606, it is now safe to implement `Read::read_buf` for file descriptors on Hermit. cc ``@mkroening``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#136320 (exit: document interaction with C) - rust-lang#138301 (Implement `read_buf` for Hermit) - rust-lang#138508 (Clarify "owned data" in E0515.md) - rust-lang#138556 (Fix ICE: attempted to remap an already remapped filename) - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`) - rust-lang#138608 (rustc_target: Add target feature constraints for LoongArch) - rust-lang#138619 (Flatten `if`s in `rustc_codegen_ssa`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#136320 (exit: document interaction with C) - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`) - rust-lang#138301 (Implement `read_buf` for Hermit) - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`) - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors) - rust-lang#138642 (Unvacation myself) - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#136320 (exit: document interaction with C) - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`) - rust-lang#138301 (Implement `read_buf` for Hermit) - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`) - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors) - rust-lang#138642 (Unvacation myself) - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#136320 (exit: document interaction with C) - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`) - rust-lang#138301 (Implement `read_buf` for Hermit) - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`) - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors) - rust-lang#138642 (Unvacation myself) - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 2, 2025
…rmit, r=tgross35 Implement `read_buf` for Hermit Following hermit-os/kernel#1606, it is now safe to implement `Read::read_buf` for file descriptors on Hermit. cc ```@mkroening```
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 2, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#136320 (exit: document interaction with C) - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`) - rust-lang#138301 (Implement `read_buf` for Hermit) - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`) - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors) - rust-lang#138642 (Unvacation myself) - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following hermit-os/kernel#1606, it is now safe to implement
Read::read_buffor file descriptors on Hermit.cc @mkroening