Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 16, 2026

Forgot about this in #145354.

Created a tracking issue in #151364.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jplatte
Copy link
Contributor

jplatte commented Jan 16, 2026

Is there a tracking issue?

@Urgau
Copy link
Member

Urgau commented Jan 16, 2026

Is there a tracking issue?

If there isn't one, we should create one and link it from the new page.

@@ -0,0 +1,3 @@
## `cache-proc-macros`

This option instructs `rustc` to cache (derive) proc-macro invocations using the incremental system. Note that this can be unsouned - we currently do not check if the macro invocation is actually "cacheable" or not.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This option instructs `rustc` to cache (derive) proc-macro invocations using the incremental system. Note that this can be unsouned - we currently do not check if the macro invocation is actually "cacheable" or not.
This option instructs `rustc` to cache (derive) proc-macro invocations using the incremental system. Note that this can be unsound - we currently do not check if the macro invocation is actually "cacheable" or not.

also, about the "we currently do not check" part, is the plan is to infer whether the proc-macro is cacheable (seems unlikely), or rather respect what the user promises about its behavior? This could just mention that enabling the flag for proc-macros that are not pure functions is bound to reuse stale extensions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather respect what the user promises about its behavior?

That is the plan, I suppose? There were a lot of proposals for this, but I don't think we have a winner :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT

@Kobzol Kobzol force-pushed the document-cache-proc-macros branch from d552bac to 345e9a0 Compare January 19, 2026 11:42
@Kobzol
Copy link
Member Author

Kobzol commented Jan 19, 2026

Created a tracking issue, mentioned it in the docs and reworded the cacheability aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants