Skip to content

Fix performance issue in liveness checking #151376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenyukang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix performance issue in liveness checking #151376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions compiler/rustc_mir_transform/src/liveness.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,11 +1086,6 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {

let Some((name, decl_span)) = self.checked_places.names[index] else { continue };

// By convention, underscore-prefixed bindings are explicitly allowed to be unused.
if name.as_str().starts_with('_') {
continue;
}

let is_maybe_drop_guard = maybe_drop_guard(
tcx,
self.typing_env,
Expand Down Expand Up @@ -1118,6 +1113,11 @@ impl<'a, 'tcx> AssignmentResult<'a, 'tcx> {
continue;
};

// By convention, underscore-prefixed bindings are explicitly allowed to be unused
if name.as_str().starts_with('_') {
continue;
}

match kind {
AccessKind::Assign => {
let suggestion = annotate_mut_binding_to_immutable_binding(
Expand Down
Loading