compiler: Require mir_opt_level > 1 for SingleUseConsts MIR pass#151426
Closed
Enselic wants to merge 1 commit intorust-lang:mainfrom
Closed
compiler: Require mir_opt_level > 1 for SingleUseConsts MIR pass#151426Enselic wants to merge 1 commit intorust-lang:mainfrom
mir_opt_level > 1 for SingleUseConsts MIR pass#151426Enselic wants to merge 1 commit intorust-lang:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default MIR opt level is 1 for non-optimized builds:
rust/compiler/rustc_session/src/session.rs
Line 581 in 0db0acd
Require
mir_opt_level > 1forSingleUseConstsMIR pass to maketests/debuginfo/basic-stepping.rswork again which builds with debuginfo but without optimizations. That test regressed when a precursor toSingleUseConstswas enabled. Well, the test didn't exist back then (I added it in #144876), but if it had existed, it would have regressed. The pass was first calledConstDebugInfobefore it was rebirthed asSingleUseConsts.This takes us one step closer towards closing #33013.