Skip to content

Improve the inline_fluent! macro#152356

Open
JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
JonathanBrouwer:inline_diag4
Open

Improve the inline_fluent! macro#152356
JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
JonathanBrouwer:inline_diag4

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Feb 8, 2026 •
edited
Loading

For #151366

This PR turns inline_fluent! into a proc macro, so we can run validation on the messages in this macro :)
I started a thread here because I don't like the name of the macro, but that's for a future PR: #t-compiler > Bikeshed the new `inline_fluent!` macro

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 8, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 8, 2026
Open
3 tasks
@JonathanBrouwer JonathanBrouwer changed the title Improve the inline_fluent! macro and rename it to msg! Improve the inline_fluent! macro Feb 8, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 8, 2026

r? @jdonszelmann

@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review February 8, 2026 21:47
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2026

rustc_errors::translation was changed

cc @davidtwco, @TaKO8Ki

rustc_macros::diagnostics was changed

cc @davidtwco, @TaKO8Ki

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 8, 2026
Merged
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 8, 2026

Don't merge together with #152276, these will soft-conflict

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 9, 2026

don't merge, #152276 goes first

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 9, 2026 •
edited
Loading

Soft conflict is now resolved, safe to merge :)
@jdonszelmann I don't think you reviewed this yet, right?
The new diff is only reformatting of messages due to #152276

@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
2 similar comments
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @jdonszelmann @rust-log-analyzer