Enforce Copy bounds for repeat elements while considering lifetimes#95819
Merged
bors merged 5 commits intorust-lang:masterfrom Apr 29, 2022
Merged
Enforce Copy bounds for repeat elements while considering lifetimes#95819bors merged 5 commits intorust-lang:masterfrom
bors merged 5 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #95477
this is a breaking change in order to fix a soundness bug.
Before this PR we only checked whether the repeat element type had an
impl Copy, but not whether that impl also had the appropriate lifetimes. E.g. if the impl was forYourType<'static>and not a general'a, then copying any type other than a'staticone should have been rejected, but wasn't.r? @lcnr