`cargo fmt` does not handle workspace member "Cargo.toml" being a symlink; gives error "Failed to find targets" #6184

tmfink · 2024-06-05T09:21:34Z

Problem

If a cargo workspace has a member project whose Cargo.toml is a symlink to a valid Cargo.toml, then running cargo fmt from the member directory fails with:

$ cargo fmt
Failed to find targets
This utility formats all bin and lib files of the current crate using rustfmt.

Usage: cargo fmt [OPTIONS] [-- <rustfmt_options>...]

Arguments:
  [rustfmt_options]...  Options passed to rustfmt

Options:
  -q, --quiet
          No output printed to stdout
  -v, --verbose
          Use verbose output
      --version
          Print rustfmt version and exit
  -p, --package <package>...
          Specify package to format
      --manifest-path <manifest-path>
          Specify path to Cargo.toml
      --message-format <message-format>
          Specify message-format: short|json|human
      --all
          Format all packages, and also their local path-based dependencies
      --check
          Run rustfmt in check mode
  -h, --help
          Print help

Here's a diff with a simple workspace that reproduces the issue.
You can git apply in an empty Git repo:

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..96ef6c0
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,2 @@
+/target
+Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
new file mode 100644
index 0000000..b7695d7
--- /dev/null
+++ b/Cargo.toml
@@ -0,0 +1,8 @@
+[workspace]
+resolver = "2"
+
+# lists member "concrete" crates that are in the virtual workspace
+members = [
+    "lib_a",
+    "main",
+]
diff --git a/lib_a/Cargo.toml b/lib_a/Cargo.toml
new file mode 120000
index 0000000..01b4380
--- /dev/null
+++ b/lib_a/Cargo.toml
@@ -0,0 +1 @@
+../lib_a_Cargo.toml
\ No newline at end of file
diff --git a/lib_a/src/lib.rs b/lib_a/src/lib.rs
new file mode 100644
index 0000000..211bfff
--- /dev/null
+++ b/lib_a/src/lib.rs
@@ -0,0 +1,3 @@
+pub fn add(left: usize, right: usize) -> usize {
+    left + right
+}
diff --git a/lib_a_Cargo.toml b/lib_a_Cargo.toml
new file mode 100644
index 0000000..bab3991
--- /dev/null
+++ b/lib_a_Cargo.toml
@@ -0,0 +1,6 @@
+[package]
+name = "lib_a"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]
diff --git a/main/Cargo.toml b/main/Cargo.toml
new file mode 100644
index 0000000..bd9e3fa
--- /dev/null
+++ b/main/Cargo.toml
@@ -0,0 +1,7 @@
+[package]
+name = "main"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]
+lib_a = { path = "../lib_a" }
diff --git a/main/src/main.rs b/main/src/main.rs
new file mode 100644
index 0000000..e7a11a9
--- /dev/null
+++ b/main/src/main.rs
@@ -0,0 +1,3 @@
+fn main() {
+    println!("Hello, world!");
+}
diff --git a/src/main.rs b/src/main.rs
new file mode 100644
index 0000000..e7a11a9
--- /dev/null
+++ b/src/main.rs
@@ -0,0 +1,3 @@
+fn main() {
+    println!("Hello, world!");
+}

Steps

Create cargo workspace project
Convert one member project's Cargo.toml to a symlink
cd into member project directory from previous step
run cargo fmt

Notes

Interestingly, even if all of the Cargo.toml files are symlinks, the issue does not occur when running cargo fmt from the root of the workspace.

Version

This occurs on the latest stable and nightly versions of rustfmt as of submitting:

$ cargo fmt --version
rustfmt 1.7.0-stable (9b00956 2024-04-29)

$ cargo +nightly fmt --version
rustfmt 1.7.0-nightly (a330e49 2024-06-04)

(Migrated from rust-lang/cargo#14012 since cargo-fmt lives in rust repo, not cargo repo)

The text was updated successfully, but these errors were encountered:

ehuss · 2024-06-05T14:30:20Z

Rustfmt has its own repository.

@bors transfer rustfmt

ehuss · 2024-06-05T14:30:43Z

@rustbot transfer rustfmt

tmfink · 2024-06-06T08:26:18Z

The issue occurs due to use of camino::Utf8Path::canonicalize() on the Cargo.toml path, which resolves symlinks:

Returns the canonical, absolute form of the path with all intermediate components normalized and symbolic links resolved.

The use is in get_targets_root_only() in src/cargo-fmt/main.rs:

rustfmt/src/cargo-fmt/main.rs

Lines 388 to 389 in c97996f

    
           || PathBuf::from(&p.manifest_path) 
        
               .canonicalize()

The get_targets_root_only() function tries to enumerate targets where the canonicalized path of the Cargo.toml is the same as the current directory joined with Cargo.toml.
However, if Cargo.toml is a symlink, then those paths will never equal and the targets are never found.
Hence, the error Failed to find targets.

The canonicalize() function resolves symlinks, which would cause targets whose "Cargo.toml" is a symlink to be filtered out. This would cause `cargo-fmt` to print an error "Failed to find targets". Resolves rust-lang#6184

epage · 2024-09-04T21:45:34Z

Unrelated to fixing this, I'm curious what use cases people have for symlinking Cargo.toml. Was considering changing Cargo's behavior around it (resolving the symlink early, possibly changing where the TARGET_DIR is) and wanting to understand the potential impact.

tmfink · 2024-09-04T22:50:07Z

Unrelated to fixing this, I'm curious what use cases people have for symlinking Cargo.toml.

I have a comment on the "path_bases" RFC that goes into detail: rust-lang/rfcs#3529 (comment)
The "path_bases" RFC would solve the problem as well, but it is not yet implemented.

My company has a custom external build system that calls cargo. The Rust projects need to be able to consume "published" Rust sources that comes from a path that is only known at build time. However, cargo does not support expanding environment variables in the Cargo.toml.

To workaround this, our build system currently:

Generates Cargo.toml from a template (variables get expanded)
Writes the generated Cargo.toml to the "object directory" since the build system does not like writing into the "source directory"
Creates a Cargo.toml symlink in the Rust project's directory to the generated Cargo.toml (which is in the "object directory")

Example `Cargo.toml` template expansion

Input template:

[dependencies]
foo = { path = "${MY_PUBLISH}/path/to/rust/crate/foo" }

Output Cargo.toml:

[dependencies]
foo = { path = "/very/long/path/to/publish/2024-01-01/path/to/rust/crate/foo" }

tmfink added the C-bug label Jun 5, 2024

rustbot added the needs-triage label Jun 5, 2024

tmfink mentioned this issue Jun 5, 2024

cargo fmt does not handle workspace member "Cargo.toml" being a symlink; gives error "Failed to find targets" rust-lang/cargo#14012

Closed

rustbot transferred this issue from rust-lang/rust Jun 5, 2024

tmfink linked a pull request Jun 7, 2024 that will close this issue

Handle Cargo.toml manifests that are symlinks #6189

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`cargo fmt` does not handle workspace member "Cargo.toml" being a symlink; gives error "Failed to find targets" #6184

`cargo fmt` does not handle workspace member "Cargo.toml" being a symlink; gives error "Failed to find targets" #6184

tmfink commented Jun 5, 2024

ehuss commented Jun 5, 2024

ehuss commented Jun 5, 2024

tmfink commented Jun 6, 2024

epage commented Sep 4, 2024

tmfink commented Sep 4, 2024

cargo fmt does not handle workspace member "Cargo.toml" being a symlink; gives error "Failed to find targets" #6184

cargo fmt does not handle workspace member "Cargo.toml" being a symlink; gives error "Failed to find targets" #6184

Comments

tmfink commented Jun 5, 2024

Problem

Steps

Notes

Version

ehuss commented Jun 5, 2024

ehuss commented Jun 5, 2024

tmfink commented Jun 6, 2024

epage commented Sep 4, 2024

tmfink commented Sep 4, 2024

Example Cargo.toml template expansion

`cargo fmt` does not handle workspace member "Cargo.toml" being a symlink; gives error "Failed to find targets" #6184

`cargo fmt` does not handle workspace member "Cargo.toml" being a symlink; gives error "Failed to find targets" #6184

Example `Cargo.toml` template expansion