Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of comment indentation on opening line of a block #4715

Closed
wants to merge 1 commit into from

Conversation

whizsid
Copy link
Contributor

@whizsid whizsid commented Feb 22, 2021

Fixes #3255 , #3994

@whizsid whizsid marked this pull request as draft February 22, 2021 19:01
@calebcartwright
Copy link
Member

Thanks for the PR! However, I don't want to get into the position of moving comments more than they already are, and would rather simply try to honor their original placement. I feel like moving up instead of down would just trade one set of problems/incorrect placement of comments with another set.

In addition to intentional same-line comments, we'll also inevitably have folks that temporarily comment something out that shouldn't be moved at all and many that likely run into that with format-on-save feature in their editors.

Do you want to try to update this to maintain the same line positioning instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment indentation on opening line of a block is incorrect
2 participants