Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic on failure to format generics in enum #6396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix panic on failure to format generics in enum #6396

wants to merge 2 commits into from
+87 −13

Commits on Nov 29, 2024

  1. fix panic on failure to format generics in enum 

    - related issues: rust-lang#5738, rust-lang#6137, rust-lang#6318, rust-lang#6378
- instead of calling unwrap(), restore original snippet when we fail to format generics in enum
- we need to propagate this rewrite failure later
    @ding-young
    ding-young committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    ff6ebd3 View commit details
    Browse the repository at this point in the history

  2. refactor visit_enum 

    - introduce format_enum that returns Rewrite
- early return when it fails to format the generics in enum
    @ding-young
    ding-young committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    af03169 View commit details
    Browse the repository at this point in the history