Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFront invalidations for docs-rs staging #237

Open
rylev opened this issue Feb 13, 2023 · 2 comments
Open

CloudFront invalidations for docs-rs staging #237

rylev opened this issue Feb 13, 2023 · 2 comments
Labels
doc-rs Related to docs-rs infra staging Related to a staging environment

Comments

@rylev
Copy link
Member

rylev commented Feb 13, 2023

The docs-rs staging environment does not support for CloudFront invalidations which happens through the CLOUDFRONT_DISTRIBUTION_ID_WEB and CLOUDFRONT_DISTRIBUTION_ID_STATIC environment variables. These needed to be added to the web and background builder.

@rylev rylev added doc-rs Related to docs-rs infra staging Related to a staging environment labels Feb 13, 2023
@syphar
Copy link
Member

syphar commented Feb 13, 2023

actually, if I'm not missing something,

only the builder & the registry watcher need these variables for invalidations.

@Mark-Simulacrum
Copy link
Member

FWIW long-term I expect we'll want to make sure that environments executing arbitrary code (i.e. the builder) have fairly locked down access, ideally not direct access to database and APIs like cloudfront etc.

Definitely not a blocker to doing this, just wanted to note somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-rs Related to docs-rs infra staging Related to a staging environment
Projects
None yet
Development

No branches or pull requests

3 participants