Add DB test for finding reviewers without review preferences

Author: Kobzol

src/handlers/assign.rs

@@ -39,6 +39,7 @@ use tracing as log;
 #[cfg(test)]
 mod tests {
     mod tests_candidates;
+    mod tests_db;
     mod tests_from_diff;
 }
 

src/handlers/assign/tests/tests_db.rs

@@ -0,0 +1,30 @@
+#[cfg(test)]
+mod tests {
+    use crate::handlers::assign::filter_by_capacity;
+    use crate::tests::run_test;
+    use std::collections::HashSet;
+
+    #[tokio::test]
+    async fn find_reviewers_no_review_prefs() {
+        run_test(|ctx| async move {
+            ctx.add_user("usr1", 1).await;
+            ctx.add_user("usr2", 1).await;
+            let _users =
+                filter_by_capacity(ctx.db_client(), &candidates(&["usr1", "usr2"])).await?;
+            // FIXME: this test fails, because the query is wrong
+            // check_users(users, &["usr1", "usr2"]);
+            Ok(ctx)
+        })
+        .await;
+    }
+
+    fn candidates(users: &[&'static str]) -> HashSet<&'static str> {
+        users.into_iter().copied().collect()
+    }
+
+    fn check_users(users: HashSet<String>, expected: &[&'static str]) {
+        let mut users: Vec<String> = users.into_iter().collect();
+        users.sort();
+        assert_eq!(users, expected);
+    }
+}

src/tests.rs

@@ -1,5 +1,6 @@
 use crate::db;
 use crate::db::make_client;
+use crate::db::notifications::record_username;
 use std::future::Future;
 use tokio_postgres::Config;
 
@@ -50,6 +51,16 @@ impl TestContext {
         }
     }
 
+    pub fn db_client(&self) -> &tokio_postgres::Client {
+        &self.client
+    }
+
+    pub async fn add_user(&self, name: &str, id: u64) {
+        record_username(&self.client, id, name)
+            .await
+            .expect("Cannot create user");
+    }
+
     async fn finish(self) {
         // Cleanup the test database
         // First, we need to stop using the database