Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/remove aliasing checks in constructors #919

Closed
2 tasks done
jturner314 opened this issue Feb 16, 2021 · 0 comments · Fixed by #1413
Closed
2 tasks done

Add/remove aliasing checks in constructors #919

jturner314 opened this issue Feb 16, 2021 · 0 comments · Fixed by #1413
Assignees
@bluss
Labels
bug
Milestone
0.16.0

Comments

@jturner314
Copy link
Member

jturner314 commented Feb 16, 2021 •
edited by bluss
Loading

@jturner314 jturner314 mentioned this issue Mar 13, 2021
Merged
@bluss bluss added the bug label Mar 27, 2021
@bluss bluss added this to the 0.16.0 milestone May 21, 2021
@bluss bluss self-assigned this Aug 2, 2024
@bluss bluss mentioned this issue Aug 2, 2024
Merged
bluss added a commit that referenced this issue Aug 3, 2024
@bluss
Check for aliasing in RawViewMut::from_shape_ptr
8240862 
It should deny overlapping indexes. Because it's an unsafe function and
we only do these checks on best-effort basis (caller has to ensure they
are correct), it's a debug assertion.

Removed the small addition to a doc comment that was done in a previous
PR (it was an unfinished idea).

Similar to pr #1410
Finishes and closes #919
@bluss bluss mentioned this issue Aug 3, 2024
Merged
bluss added a commit that referenced this issue Aug 3, 2024
@bluss
Check for aliasing in RawViewMut::from_shape_ptr
0e9f7f7 
It should deny overlapping indexes. Because it's an unsafe function and
we only do these checks on best-effort basis (caller has to ensure they
are correct), it's a debug assertion.

Removed the small addition to a doc comment that was done in a previous
PR (it was an unfinished idea).

Similar to pr #1410
Finishes and closes #919
@bluss bluss closed this as completed in b03953a Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluss bluss

Labels
bug
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Check for aliasing in RawViewMut::from_shape_ptr with a debug assertion rust-ndarray/ndarray
2 participants
@jturner314 @bluss