Replace block module with helper functions
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
commented
Nov 10, 2025
| # To build locally: | ||
| # RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --all-features --no-deps --open | ||
| all-features = true | ||
| rustdoc-args = ["--generate-link-to-definition"] |
Member
Author
There was a problem hiding this comment.
Do we still need --generate-link-to-definition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to remove the
serdefeature and reduce total amount of code in the crate. Additionally, the helper functions use the lazy block generation and store cursor position in the first buffer value, which should be a bit more efficient.The
lemodule is renamed toutilsand now contains the new helper function.The new examples demonstrate implementation of the traits for the most common RNG classes.
TODO:
fill_bytes_via_next?