Skip to content

Commit 835a2f2

Browse files
ruvnetruvnet
andcommitted
fix(ci): exclude npm/ binaries from .node file search in publish workflow
The find command in 'Copy to platform package' was picking up the already-committed .node files in crates/ruvector-attention-node/npm/ and then trying to cp them to themselves, causing exit code 1. Fix: add `! -path "*/npm/*"` so only freshly built target artifacts are found. Applied to both publish-all.yml and build-attention.yml. Co-Authored-By: claude-flow <ruv@ruv.net>
1 parent b4f9981 commit 835a2f2

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎.github/workflows/build-attention.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ jobs:
9494
- name: Copy to platform package
9595
shell: bash
9696
run: |
97-
# Find the built .node file
98-
NODE_FILE=$(find crates/ruvector-attention-node -name "*.node" -type f | head -1)
97+
# Find the built .node file (exclude committed npm/ platform binaries)
98+
NODE_FILE=$(find crates/ruvector-attention-node -name "*.node" -type f ! -path "*/npm/*" | head -1)
9999
100100
if [ -z "$NODE_FILE" ]; then
101101
echo "ERROR: No .node file found"
@@ -141,7 +141,7 @@ jobs:
141141
continue-on-error: true
142142
shell: bash
143143
run: |
144-
NODE_FILE=$(find crates/ruvector-attention-node -name "*.node" -type f | head -1)
144+
NODE_FILE=$(find crates/ruvector-attention-node -name "*.node" -type f ! -path "*/npm/*" | head -1)
145145
echo "Testing: $NODE_FILE"
146146
node -e "
147147
const native = require('./$NODE_FILE');

‎.github/workflows/publish-all.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ jobs:
125125
- name: Copy to platform package
126126
shell: bash
127127
run: |
128-
NODE_FILE=$(find crates/ruvector-attention-node -name "*.node" -type f | head -1)
128+
NODE_FILE=$(find crates/ruvector-attention-node -name "*.node" -type f ! -path "*/npm/*" | head -1)
129129
mkdir -p "crates/ruvector-attention-node/npm/${{ matrix.settings.platform }}"
130130
cp -v "$NODE_FILE" "crates/ruvector-attention-node/npm/${{ matrix.settings.platform }}/${{ matrix.settings.node_file }}"
131131

0 commit comments

Comments
 (0)