Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write an automated test which pulls a random set of workflows from comfyworkflows.com to test for stability #71

Open
oxysoft opened this issue Nov 10, 2023 · 8 comments

Comments

@oxysoft
Copy link

oxysoft commented Nov 10, 2023

Every single workflow I try to import fails. This is a recurrent problem in CushyStudio. So far I have never been able to import my own workflows into CushyStudio in the two months that I have toyed with it on and off. This makes CushyStudio mostly useless so it's very important that we get this essential functionality perfect.

https://comfyworkflows.com/

@rvion
Copy link
Owner

rvion commented Nov 10, 2023

image

adding that now

@rvion
Copy link
Owner

rvion commented Nov 10, 2023

image

first step: display those in the action picker with their illustration

@rvion
Copy link
Owner

rvion commented Nov 10, 2023

image

all those random workflows picked on https://comfyworkflows.com/ now both show in the library + load when you click on them; (except for the bottom-left one that uses Reroute (rgthree))

@rvion
Copy link
Owner

rvion commented Nov 10, 2023

image

honestly, I won't debug those kind of things 😄
they just don't make any sense in Cushy.
I've already added some stuff to support some frontend-only nodes that only exist in the litegraph UI, but that's just the wrong approach; what I want is to be able to load any workflow in the ComfyUi panel (100% of existing workflows are supported there)
then allow you to select any subset of nodes => right click => make into prefab => it creates a file ready to be used/and reused across your actions

@rvion
Copy link
Owner

rvion commented Nov 10, 2023

image

I've made the auto-generated form way better; not finished yet, but quite promising

@oxysoft
Copy link
Author

oxysoft commented Nov 11, 2023

image

honestly, I won't debug those kind of things ?? they just don't make any sense in Cushy. I've already added some stuff to support some frontend-only nodes that only exist in the litegraph UI, but that's just the wrong approach; what I want is to be able to load any workflow in the ComfyUi panel (100% of existing workflows are supported there) then allow you to select any subset of nodes => right click => make into prefab => it creates a file ready to be used/and reused across your actions

Lmao I will admit I didn't know the extent to which people pushed this. I still think Cushy should be able to display it at all cost, even if it's just collecting every node into a list for editing and running.

image

I've made the auto-generated form way better; not finished yet, but quite promising

Now that looks more like what I expected going into Cushy Studio. I think you should add a subtle separator between each node in the list, or even better make the background color alternating subtly on a node-by-node basis!

@rvion
Copy link
Owner

rvion commented Nov 11, 2023

image

some field are now mapped to their better widget alternative

@rvion
Copy link
Owner

rvion commented Nov 11, 2023

respect min, max, step

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants