Skip to content

Tiny improvement for read_() #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tiny improvement for read_() #25

wants to merge 4 commits into from

Conversation

@ooichu
Copy link

@ooichu ooichu commented Feb 10, 2023 •
edited
Loading

Before this change, if the line break was \r, comments didn't work correctly.

@ooichu
Some fixes for 'read_'
e5b92dd 
Before this change, if the line break was `\r`, comments didn't work correctly. Fixed a bug in `read_`, now you can add a '\' character before 'n', 'r', 't'.
@ooichu ooichu changed the title Some fixes for 'read_' Some fixes for read_ Feb 10, 2023
@ooichu ooichu changed the title Some fixes for read_ Tiny improvement for read_ Feb 18, 2023
@ooichu ooichu changed the title Tiny improvement for read_ Tiny improvement for read_() Feb 20, 2023
@ooichu
Copy link
Author

ooichu commented Feb 25, 2023

As a consequence, if you open a file which uses \r as line termination, any ; will comment out the entire file. This will not happen (it is probably not 100% portable) if you open a file with the flag "r" instead of "rb".

@ooichu
Copy link
Author

ooichu commented Apr 22, 2023

Found a little bug. After opening context gcstack_idx is equal to 4. This happens because the stack index is saved after the t symbol is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ooichu