Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail authentication - PHP notice when registered user types in wrong password #6

Open
WebWorkingMan opened this issue Oct 14, 2017 · 3 comments

Comments

@WebWorkingMan
Copy link

WebWorkingMan commented Oct 14, 2017

Hey, I've figured out an error:

I'm using the option "Use email address for login rather than user name". When a registered user tries to login and types in the wrong password I get an PHP notice:

Notice: Trying to get property of non-object in /mnt/***/site/modules/LoginRegister/LoginRegister.module on line 394

This behavior is reproducible on two sites of mine

@salvw
Copy link

salvw commented Apr 26, 2018

Also, if a user types in a wrong password a few times (and the right e-mail) Session Login Throttle kicks in and leaves the user with a internal server error instead of a helpful message.

@somatonic
Copy link

Same here, on first test to login....

As for the Login Throttle see: #10

@Toutouwai
Copy link

Line 394 needs to be changed to something like:

$name = $user ? $user->name : null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants