Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The command in README.md does not replace some urls #35

Open
34j opened this issue Mar 24, 2024 · 2 comments
Open

The command in README.md does not replace some urls #35

34j opened this issue Mar 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@34j
Copy link

34j commented Mar 24, 2024

Current Behavior

I have used it for the first time in a while, but #22 still seems to be unresolved.

The commit below show some places I have found that should be changed but are not. I think this is all.
34j/hexo-renderer-pdf@f7df450

Without this, the GitHub repository could not be found and the release action could not be done properly.

Thanks for the your great template.

Expected Behavior

Steps to Reproduce the Problem

  1. Use template
  2. Run the command in README.md

Environment

  • Version: Latest
  • Platform: Win
  • Node.js Version:
@34j 34j added the bug Something isn't working label Mar 24, 2024
@34j
Copy link
Author

34j commented Mar 24, 2024

I hadn't noticed #34 🤣, it shoud fix this

@moontai0724
Copy link

moontai0724 commented Apr 9, 2024

LOL seems the MR has been accidentally closed while I'm cleaning up my repos.

But you may use the fixed script in the MR changed list:

sed -i.tmp "s/\([^@]\)ryansonshine/\1$GITHUB_USER/g; s/typescript-npm-package-template\|my-package-name/$REPO_NAME/g; s/Ryan Sonshine/$FULL_NAME/g" package.json package-lock.json README.md
rm *.tmp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants