-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jackknife+ Implementation #10
Comments
To implement jackknife+ we added a new function called conformal.pred.jackplus and also one more return argument to lm.funs , called update.fun. Since the algoritm is quite computationally expensive, we implemented a series of workarounds:
The function takes as input: The function returns a list with the following components: pred, lo, up, split. They have the same structure as the return of conformal.pred.split. We also built an example script, called ex.conformal.pred.jackplus, to test the code, similarly to the already |
@paolo-vergo Sorry for the long delay here. Thanks for writing this out. Several questions/comments.
|
|
Hi @paolo-vergo, me again, apologizing for such a long delay here. It's been really tough to find time to check-in and think about this. I'm really sorry to keep you guys waiting so long. While we figure out what to do vis-a-vis jackknife+ with local-weighting, why don't you go head and submit a PR or at least a draft PR with this just to get the ball rolling. I've sent out a message to try to see if I can get some help from collaborators / students / people in the conformal community in terms of maintaining this package so hopefully if we can find said people, they will be able to jump in, discuss issues, tend to pull requests, etc., and the whole thing won't be moving so slowly. Thank you for your patience and sorry again ... |
Hi @ryantibs, as requested I have sent the PR for the Jackknife+ (without local weighting) ! |
Hi @paolo-vergo thinking about it and discussing it with my friend Rina (lead author on the jack+ paper) this should be the right way to do locally-weighted conformal with jackknife+: lower and upper quantiles of \hat\mu_{-i}(X_{n+1}) +/- \hat\sigma_{-i}(X_{n+1}) R_i where R_i is the studentized leave-one-out residual R_i = |Y_i - \hat\mu_{-i}(X_{n+1})| / \hat\sigma_{-i}(X_i) Make sense? |
Hi @ryantibs ! It makes sense to me. Therefore I have implemented the local weighting and committed the changes on my branch. |
It would be useful to implement, as a prediciton method, the Jaccknife+ by Barber and coauthors (https://arxiv.org/abs/1905.02928)
The text was updated successfully, but these errors were encountered: