Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Animate components when they render in/out #14

Closed
14 tasks done
ryqndev opened this issue Sep 4, 2020 · 1 comment
Closed
14 tasks done

[Feature] Animate components when they render in/out #14

ryqndev opened this issue Sep 4, 2020 · 1 comment
Labels
feature Brand new feature or functionality.

Comments

@ryqndev
Copy link
Owner

ryqndev commented Sep 4, 2020

Proposed Feature:

Add animations when components render in/out

Setup ReactCSSTransitionGroup

  • setup

Components to animate:

  • History -> DrinkPanels
  • Feed -> FeedItem
  • Feed -> ExpandedFeedItem
  • Blog -> FeedItem
  • UserModal
  • UserModal -> Help

If Possible:

  • Make Text changes smoother (not sure how but they seem abrupt atm)

If #12 is implemented,

  • Animate Page transitions
    • Dashboard
    • History*
    • Add
    • Feed*
    • Blog*

note * individual components as content of page may already be animated

@ryqndev ryqndev added the feature Brand new feature or functionality. label Sep 4, 2020
@ryqndev
Copy link
Owner Author

ryqndev commented Sep 12, 2020

Implemented Features:

cc1a72c <- Tested out CSSTransitions before applying to entire app. Created animations.scss file

951d63e <- Wrapped individual pages in CSSTransitions for page transitions.

Not implemented:

  • Blog/Feed aren't wrapped in CSSTransitions and individual components animated instead of page. There was a routing issue and didn't feel it was worth looking into since individual components are already animated.
  • Text Changes will be fulfilled in the separate Text Component.

@ryqndev ryqndev closed this as completed Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature or functionality.
Projects
None yet
Development

No branches or pull requests

1 participant