Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayer setting - no cancel button on popup #19

Open
piotrpog opened this issue Sep 4, 2022 · 1 comment
Open

Displayer setting - no cancel button on popup #19

piotrpog opened this issue Sep 4, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@piotrpog
Copy link

piotrpog commented Sep 4, 2022

When we open popup, sometimes we cannot close it without saving settings, unless we refresh whole page. There is only "save" button.

image

These are settings for accordion "displayer", for author "property".

@ryssbowh
Copy link
Owner

ryssbowh commented Sep 5, 2022

This has to do with Vue, changing values here will change the values of the displayers whether you click Cancel or Save. Clicking Save will validate the options, Cancel would not and it would be even more confusing.

Adding a Cancel button would mean remembering the state of the displayers before you changed anything, so it can be reverted. I'll have a look what can be done

@ryssbowh ryssbowh added the enhancement New feature or request label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants