refactor(parser): 🔨 add more code cleanup

Author: s0cks

libtaskfile-parser/include/taskfile_parser.h

@@ -131,6 +131,7 @@ static inline bool StrViewIsEmpty(const StrView view) {
 static inline bool StrViewEquals(const StrView a, const StrView b) {
   if (a.len != b.len)
     return false;
+
   return a.len == 0 || memcmp(a.start, b.start, a.len) == 0;
 }
 
@@ -862,6 +863,8 @@ StrView GetDocumentVersion(Document* doc);
 uint64_t GetNumberOfTasksInDocument(Document* rhs);
 TaskNode* GetDocumentTaskAt(Document* doc, const uint64_t idx);
 TaskNode* FindDocumentTask(Document* doc, const StrView name);
+void VisitDocumentTasks(Document* doc, TaskVisitor vis, void* data);
+void VisitDocumentTasksMatch(Document* doc, TaskPredicate predicate, TaskVisitor vis, void* data);
 
 static inline bool DocumentHasTasks(Document* rhs) {
   return GetNumberOfTasksInDocument(rhs) > 0;

libtaskfile-parser/src/document.c

@@ -146,11 +146,13 @@ TaskNode* GetDocumentTaskAt(Document* doc, const uint64_t idx) {
 TaskNode* FindDocumentTask(Document* doc, const StrView name) {
   if (!doc)
     return NULL;
-  for (uint64_t i = 0; i < GetNumberOfTasksInSeq(&doc->tasks); i++) {
+
+  for (size_t i = 0; i < GetNumberOfTasksInSeq(&doc->tasks); i++) {
     TaskNode* task = GetTaskInSeqAt(&doc->tasks, i);
     if (StrViewEquals(task->name, name))
       return task;
   }
+
   return NULL;
 }
 
@@ -165,11 +167,13 @@ VarNode* GetDocumentVarAt(Document* doc, const uint64_t idx) {
 VarNode* FindDocumentVar(Document* doc, const StrView name) {
   if (!doc)
     return NULL;
+
   for (uint64_t i = 0; i < GetNumberOfVarsInSeq(&doc->vars); i++) {
     VarNode* var = GetVarInSeqAt(&doc->vars, i);
     if (StrViewEquals(var->name, name))
       return var;
   }
+
   return NULL;
 }
 
@@ -271,6 +275,7 @@ void VisitDocumentCommentsMatching(Document* doc, CommentPredicate predicate, Co
 void VisitDocumentTasks(Document* doc, TaskVisitor vis, void* data) {
   if (!doc)
     return;
+
   VisitTasksInSeq(&doc->tasks, vis, data);
 }