The rh_emit_sound2 native is broken

[DarthMan]

Hello, it seems that the rh_emit_sound2 native is broken. I wrote a plugin example that I tested on TFC.

Didn't test in other mods, but since it's broken on Team Fortress Classic, I guess it is on all of them.
Hope it will be fixed :)

#include <amxmodx>
#include <reapi>

new const umbrella_sound[] = "weapons/cbar_miss1.wav";

public plugin_init() {
    register_clcmd("say /sound", "PlaySound");
}

public PlaySound(id) {
    rh_emit_sound2(id, id, CHAN_ITEM, umbrella_sound, VOL_NORM, ATTN_NORM, 0, PITCH_NORM);
}

public plugin_precache() {
    precache_sound(umbrella_sound);
}

[WPMGPRoSToTeMa]

rh_emit_sound2 uses checks that are specific to the CS gamedll:

reapi/reapi/src/natives/natives_misc.cpp

Lines 2657 to 2663 in efcc395

	CBaseEntity *pRecipient = getPrivate<CBaseEntity>(params[arg_recipient]);
	CHECK_CONNECTED(pRecipient, arg_recipient);
	// ignore recipient of non-player
	if (params[arg_recipient] != 0 && pRecipient && !pRecipient->IsNetClient()) {
	return FALSE;
	}

CHECK_CONNECTED uses has_disconnected field which is present only in CS. IsNetClient also cannot be used in cross-game code because function offsets inside vtables aren't the same across the different games.

rh_update_user_info is also affected by this:

reapi/reapi/src/natives/natives_misc.cpp

Lines 2689 to 2690 in efcc395

	CBasePlayer *pPlayer = getPrivate<CBasePlayer>(params[arg_playerEntIndex]);
	CHECK_CONNECTED(pPlayer, arg_playerEntIndex);

There are also common natives affected:

• GetGrenadeType - but I hope it should be CS-specific anyway
• engset_view
• GetBonePosition - not sure
• GetAttachment - not sure
• SetThink - should rely on gamedata to be not CS-specific
• SetTouch - same as SetThink
• SetUse - same as SetThink
• SetBlocked - same as SetThink
• SetMoveDone - same as SetThink
• is_entity

[DarthMan]

rh_emit_sound2 uses checks that are specific to the CS gamedll:

reapi/reapi/src/natives/natives_misc.cpp

Lines 2657 to 2663 in efcc395

	CBaseEntity *pRecipient = getPrivate<CBaseEntity>(params[arg_recipient]);
	CHECK_CONNECTED(pRecipient, arg_recipient);
	// ignore recipient of non-player
	if (params[arg_recipient] != 0 && pRecipient && !pRecipient->IsNetClient()) {
	return FALSE;
	}

CHECK_CONNECTED uses has_disconnected field which is present only in CS. IsNetClient also cannot be used in cross-game code because function offsets inside vtables aren't the same across the different games.

rh_update_user_info is also affected by this:

reapi/reapi/src/natives/natives_misc.cpp

Lines 2689 to 2690 in efcc395

	CBasePlayer *pPlayer = getPrivate<CBasePlayer>(params[arg_playerEntIndex]);
	CHECK_CONNECTED(pPlayer, arg_playerEntIndex);

There are also common natives affected:

• GetGrenadeType - but I hope it should be RG specific anyway
• engset_view
• GetBonePosition - not sure
• GetAttachment - not sure
• SetThink - should rely on gamedata to be not RG specific
• SetTouch - same as SetThink
• SetUse - same as SetThink
• SetBlocked - same as SetThink
• SetMoveDone - same as SetThink
• is_entity

Then I guess since they rely on CS they must be moved to regamedll or if not in the native description it should be stated that all the mentioned natives are only for CS only.