Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite CORS changes #17

Closed
s2b opened this issue Jan 22, 2025 · 2 comments
Closed

Vite CORS changes #17

s2b opened this issue Jan 22, 2025 · 2 comments

Comments

@s2b
Copy link
Owner

s2b commented Jan 22, 2025

Recent changes in vite enabled CORS by default. Currently, there is no way to disable it without specifying it in a configuration file. Since this add-on doesn't and shouldn't include a vite config (this is the responsibility of the project), this might decrease the developer experience.

Issue in vite tracker: vitejs/vite#19263

@rfay
Copy link

rfay commented Jan 30, 2025

@s2b
Copy link
Owner Author

s2b commented Feb 4, 2025

It's probably not a good idea to re-allow CORS from all domains by setting --cors in ddev vite. Since it's not possible to limit CORS headers to specific URIs via CLI options, that configuration can't be the responsibility of this add-on and needs to be configured in vite config by the user.

@s2b s2b closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants