Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to retry operations with retry count and timeout #73

Open
s8sg opened this issue Jul 26, 2019 · 5 comments
Open

Add options to retry operations with retry count and timeout #73

s8sg opened this issue Jul 26, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request high-priority SDK Issue applies to component SDK

Comments

@s8sg
Copy link
Owner

s8sg commented Jul 26, 2019

Retry an operation if failed or timeout happen. If configured, when a operation fails the it will be retried, for n time. Where n is less than retry count.

@s8sg s8sg added the enhancement New feature or request label Jul 26, 2019
@vtolstov
Copy link
Contributor

vtolstov commented Aug 2, 2019

May be good to have backoff interval for retry

@s8sg
Copy link
Owner Author

s8sg commented Aug 6, 2019

@vtolstov
do you think its good have it integrated within the executor. Then the changes will be in sdk and applicable for all operation.

Alternatively we may let user handle it in ExecuteOperation() call. In that case it will be only at faas-flow template level changes

@vtolstov
Copy link
Contributor

vtolstov commented Aug 6, 2019

I think about it, in case of put it in ExecuteOperation all users needs to add logic to retry, timeouts and backoff. I think that timeout is the core stuff..

@s8sg s8sg added the SDK Issue applies to component SDK label Aug 7, 2019
@vtolstov
Copy link
Contributor

@s8sg when you can do retries and timeouts?
Or how can i add it to provide pr (in case od adding it to sdk)

@s8sg
Copy link
Owner Author

s8sg commented Aug 11, 2019

I’m really busy. I’ll do that as soon as I manage some time. Great if you can raise a PR. I haven’t made any progress so far on this one

@s8sg s8sg changed the title Add options to retry operations with retry count Add options to retry operations with retry count and timeout Aug 26, 2019
@s8sg s8sg self-assigned this Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority SDK Issue applies to component SDK
Projects
None yet
Development

No branches or pull requests

2 participants