Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle javafx modules #6

Merged
merged 6 commits into from
Feb 4, 2021
Merged

Handle javafx modules #6

merged 6 commits into from
Feb 4, 2021

Conversation

cmhulbert
Copy link
Contributor

Prepend JavaFx module path to jvm args to run Paintera with JavaFx 13

  • Add the appropraite --module-path based on the jgo cache directory
  • --add-opens the the internal APIs utilized by paintera
  • --add-modules the javafx modules

Note: This should be updated to take advantage of jgo's internal --module-path handling when scijava/jgo#60 is merged.

@cmhulbert cmhulbert requested a review from axtimwalde February 1, 2021 19:44
@cmhulbert cmhulbert marked this pull request as draft February 1, 2021 22:54
@cmhulbert cmhulbert marked this pull request as ready for review February 2, 2021 19:41
@cmhulbert cmhulbert marked this pull request as draft February 3, 2021 15:49
@cmhulbert cmhulbert marked this pull request as ready for review February 3, 2021 16:08
axtimwalde
axtimwalde approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@axtimwalde axtimwalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

paintera/javafx_modules.py Outdated Show resolved Hide resolved
@axtimwalde axtimwalde merged commit c3f491a into master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axtimwalde axtimwalde axtimwalde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmhulbert @axtimwalde