Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MultiResolutionRenderer from bigdataviewer-core #268

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

maarzt
Copy link

@maarzt maarzt commented Jul 26, 2019

The MultiResolutionRendererGeneric in Paintera is a fork of the MultiResolutionRenderer in BigDataViewer. This PR is part of an effort. That tries to reintegrate the changes made in Paintera into BigDataViewer.

See also bigdataviewer/bigdataviewer-core#59

Currently I try to reduce the differences between the MultiResolutionRenderer in BigDataViewer and Paintera.

@hanslovsky
Copy link
Collaborator

Great, thanks for looking into this @maarzt
This will be super helpful! Should the multi-resolution renderer (eventually) live outside bdv-core? Maybe in some imglib2 package?
cc @tpietzsch @axtimwalde for opinions

@igorpisarev
Copy link
Contributor

Hi @maarzt, thanks for the efforts!
I've modified MultiResolutionRendererGeneric here a few months ago as part of #211 to allow rendering arbitrary parts of the screen, which involved changing the logic quite a bit (as far as I remember). Let me know if I can be of any help in integrating these changes into BDV.

@maarzt
Copy link
Author

maarzt commented Jul 28, 2019

#211 is actually the main motivation to look into this. @hanslovsky @igorpisarev I have some questions.

  1. You never use ViewerState in Paintera's MultiResolutionRendererGeneric What's the motivation for that?
  2. When is setScreenScales called? Is it used often?

(I'm on holidays for one week. I will work on this afterwards.)

@hanslovsky
Copy link
Collaborator

You never use ViewerState in Paintera's MultiResolutionRendererGeneric What's the motivation for that?

We do not use the bdv ViewerState in Paintera, so we cannot pass it into the multi-resolution renderer. Ideally, the (generic) multi-resolution renderer would not have any bdv dependencies but replacing all uses of bdv's Source was prohibitively laborous at that time.

When is setScreenScales called? Is it used often?

This is used to adjust screen scales if rendering speed is too slow, e.g. for hidpi displays. This is usually set through the graphical user interface and thus called very rarely, e.g. once per Paintera session.

@cmhulbert cmhulbert marked this pull request as ready for review June 6, 2023 17:14
@cmhulbert cmhulbert marked this pull request as draft June 6, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants