Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme docs update, re-order usage table info #454

Closed

Conversation

GenevieveBuckley
Copy link
Contributor

This PR is mostly a re-ordering of existing information. Grouping the information in the "Usage" table into subsections according to function makes it easier to find the information you're looking for.

@GenevieveBuckley
Copy link
Contributor Author

Oh, hang on - there are two files called README.md (one in the top level of the repository, and one under markdown/README.md).

Most of the content seems to be duplicated. Should I also copy my changes into the second readme file as well? What's the difference between the two?

@cmhulbert
Copy link
Collaborator

The nested README.md should just be a symlink to the top level one, so you shouldn't need to explicitly copy the changes. Thanks for clearing up some of the README.md!

@GenevieveBuckley
Copy link
Contributor Author

The nested README.md should just be a symlink to the top level one, so you shouldn't need to explicitly copy the changes. Thanks for clearing up some of the README.md!

Ah, of course. I probably should have looked more closely.

I'm still not entirely sure where the content is being pulled for the key bindings dialog that pops up if you press F1 (or access it from the help menu). It seems separate from the README content. I found KeyBindingsDialog.kt, but I still don't see where it's getting the content from. Ideally these tables would also be organised in the same way, but I guess that can be done in another PR.

@GenevieveBuckley
Copy link
Contributor Author

FYI, I've also added links to the two new youtube tutorial videos under the "Usage" heading. I think that's a good place for it.

I don't plan to make more changes to this PR, unless you request them.

@GenevieveBuckley
Copy link
Contributor Author

Added some more information from Stephan's comment here, plus a link to the BigDataViewer docs on navigation controls since he says they are the same

@cmhulbert
Copy link
Collaborator

cmhulbert commented Jun 6, 2023

@GenevieveBuckley You'll see I merged your commits (as well as some other updates to the README) into the current master branch. Thanks for clearing providing these updates, definitely needed some more attention, and hopefully now it's a bit clearer. Thanks!

@cmhulbert cmhulbert closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants