You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
The label keys for Sablier are public; for example:
apiVersion: apps/v1kind: Deploymentmetadata:
name: whoamilabels:
app.kubernetes.io/name: whoami # also good practice, but not core to THIS issuesablierapp.dev/enable: "true"sablierapp.dev/group: mygroup…
Using public label keys is good practice, helps people find the documentation a little more easily, and avoids conflicting with organizations' own policies and conventions for private labels.
Additional context
Typically when Kubernetes-compatible projects adopt the official label convention(s), they add support for the new way; then they deprecate the old way (using private label keys), but continue to support it for many releases. The documentation recommends the new-style, public label keys.
Describe the bug
Sablier uses private labels (private because there is no
/
in the key). Example:Context
Expected behavior
The label keys for Sablier are public; for example:
Using public label keys is good practice, helps people find the documentation a little more easily, and avoids conflicting with organizations' own policies and conventions for private labels.
Additional context
Typically when Kubernetes-compatible projects adopt the official label convention(s), they add support for the new way; then they deprecate the old way (using private label keys), but continue to support it for many releases. The documentation recommends the new-style, public label keys.
Read https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set for Kubernetes' documentation about public vs. private label keys.
The text was updated successfully, but these errors were encountered: