Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Neovisionaries socket library #45

Open
SanderVeer opened this issue Nov 16, 2018 · 10 comments
Open

Upgrade Neovisionaries socket library #45

SanderVeer opened this issue Nov 16, 2018 · 10 comments

Comments

@SanderVeer
Copy link

Currently the library is using a nv-socket lib version that's 8 version behind the latest one.
This means the library is missing (important) features such as SNI support which is currently causing me a lot of issues on an app supporting older Android APIs.

Please upgrade the lib to use a more recent version of the Neovisionaries socket library.

@sacOO7
Copy link
Owner

sacOO7 commented Nov 21, 2018

Hi @SanderGemoro I am really sorry for delay. Expect update from me on this till tomorrow.

@SanderVeer
Copy link
Author

Hi @sacOO7 , any new updates on this front or the OkHttp socket conversion? Really looking forward to it :D

@sacOO7
Copy link
Owner

sacOO7 commented Dec 4, 2018 via email

@sacOO7
Copy link
Owner

sacOO7 commented Dec 4, 2018

Hi @SanderGemoro , I have updated the library today. You can see code on the branch here https://github.com/sacOO7/socketcluster-client-java/tree/feature/okHTTP.
Will release unofficial version of library for beta testing. Keep watching repo. for more updates.

@sacOO7
Copy link
Owner

sacOO7 commented Dec 4, 2018

Hi @SanderGemoro , I have published beta version related to above code. You can include it in your code by using

compile 'io.github.sac:SocketclusterClientJava:2.0.0-beta'

There are some method signatures which got changed due to change in library. But, you should be able to fix it without any problem. Please let me know if you face any problems with this latest release.

@sacOO7
Copy link
Owner

sacOO7 commented Dec 6, 2018

Hi @SanderGemoro , any updates on above?

@SanderVeer
Copy link
Author

I havent worked on this part in our project since your last update so I haven't had the time to try it out yet. I'll probably be able to give an update tomorrow! Thanks for your hard work!

@sacOO7
Copy link
Owner

sacOO7 commented Dec 6, 2018

Ok np...

@SanderVeer
Copy link
Author

Hey @sacOO7 ,
I just tried out your new beta client and it solved all of our issues instantly!
Like you said we did have to make some minor changes but that was a piece of cake. Our chat solution now works perfectly on devices running API 21 and up

@mike-holberger
Copy link

Wow I am really looking forward to the OkHttp release too! I will be testing out the beta release for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants