Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check if liana uses the log normalised values #104

Open
ahmetrifaioglu opened this issue Apr 24, 2024 · 1 comment
Open

Sanity check if liana uses the log normalised values #104

ahmetrifaioglu opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ahmetrifaioglu
Copy link
Member

Is your feature request related to a problem? Please describe.

Users sometimes run liana on raw or differently normalized/transformed data or forgets to set use_raw=False which results in NaN or inf. values in logfc and specificity values. That would be nice to check the input values and warn users to check if they are using the log normalised values.

Describe the solution you'd like
A clear and concise description of what you want to happen. Examples from other methods are welcome.

Just a noticeable warning that so that users check if they are using the correct input.

@ahmetrifaioglu ahmetrifaioglu added the enhancement New feature or request label Apr 24, 2024
@dbdimitrov
Copy link
Collaborator

Hi @ahmetrifaioglu, I will make sure to have it in the next update 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants