-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CellPhoneDB v5 (update and is_ppi flag) #269
Comments
@deeenes also please use the |
Maybe how I process it here would help: |
Hi Daniel, As far as I could find, pypath i already using the CellPhoneDB git as a source for the data (see here and then here), so I think it is already using the v5 version of the data. What I found out now when checking this, is that although the retrieval of interactions works fine: > from pypath.inputs import cellphonedb
> list(cellphonedb.cellphonedb_interactions())[-1]
CellphonedbInteraction(id_a='P16070', id_b='O43914', sources='CellPhoneDB', references='', interaction_type='unknown-unknown', type_a='unknown', type_b='unknown') When you try to retrieve the ligand-receptor interactions it returns a tuple of empty sets: > cellphonedb.cellphonedb_ligands_receptors()
(set(), set()) This seems to be an issue in how the complex annotations were being imported, and therefore the ligand/receptor attributes were being all labeled as Regarding the use of Since this should resolve your initial question, I'll close the issue and we can discuss the Best |
@Nic-Nic thanks Nico. Though I would say the |
I renamed the issue and reopened since the two comments are tied. The flag was introduced along with the update of the database. 🙂 |
PS. Also, there is no need to implement the flag, it's simply about setting it to False, when whe resource is obtained. We don't want to include those, and I can think of limited use of having them even if we do. |
Added the `is_ppi` flag from the interaction database of CellPhoneDB Fixes #269
Added the flag to the import method of the interactions database from CellPhoneDB (see #281). The decision on whether to filter out the |
Hey Nico, thanks a lot. I think it should definitely be In short, they assume that the last production enzyme of a metabolite in one cell type, and a receptor/enzyme of another translate to the metabolite-receptor interaction. I think it's very specific to be pull by default as ligand-receptor interactions by the clients :) |
…ropagating it to the web service (part of addressing #269)
Hey @deeenes @Nic-Nic, It seems to me that the solution we discussed yesterday for liana, i.e. access the databases via the client, will not work if we don't filter the non-ppis here. These non-ppis are either way incorporated into MetalinksDB, so for our usecases we don't need them. So, I'm re-opening the issue. Let me know if you want me to add the line that the dataframe. Daniel |
Hey @dbdimitrov, you're right, having the attribute itself doesn't result in the removal of those interactions. We need two little things:
We'll soon take care of these |
Ping @deeenes, it will become time sensitive very soon 😄 |
@deeenes 👀 |
@deeenes I am curious, if one is to use cellphonedb via Liana, what is the effect of this is_ppi not functioning correctly? Will we see erroneous interactions between enzymes and receptors? It is unclear to me because it seems like an integration between omnipath and liana, and this issue may have been addressed in the liana repo since this discussion. |
Hey Denes,
Recently, CellPhoneDB got bumped to v5, and the data is stored here:
https://github.com/ventolab/cellphonedb-data/tree/master
Seems to have changed format from:
pypath/pypath/resources/urls.py
Line 1103 in bf81f34
Let me know if I can help with this.
Daniel
The text was updated successfully, but these errors were encountered: