Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a dedicated "Notes" field, adding context to transactions #1652

Open
DefiDebauchery opened this issue Sep 4, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@DefiDebauchery
Copy link

DefiDebauchery commented Sep 4, 2023

Background

Safe has become a de facto multisig product and platform for many teams and projects.

One common issue I've seen across organizations that use Safe is contextualizing pending transactions. While this can be communicated through external means (Snapshot, Discord, etc), optionally allowing for context within Safe would be far more convenient and safer.

At Beefy, I'm currently abusing the origin field to achieve similar behavior when reporting executed transactions to our Discord, but this field is designed/expected to be from Safe Apps, and in json format. While we could continue doing this, having a dedicated text field for notes would also open up the ability to be integrated into the Safe UI, allowing more teams to explain pending transactions to other signers and to their communities, even for transactions created by those Apps like WalletConnect or the Transaction Builder.

Screenshot 2023-09-04 at 11 43 08 AM

Endpoint

As part of SafeMultisigTransaction and SafeMultisigTransactionResponse, It would be returned with the rest of the transaction details

Response

    {
      "safe": "0xc9C61194682a3A5f56BF9Cd5B59EE63028aB6041",
      "to": "0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48",
      "value": "0",
      "data": "0xa9059cbb000000000000000000000000ca74281b35b5a12484891edac0ef03d19c2dc118000000000000000000000000000000000000000000000000000000041314cf00",
...
      "safeTxHash": "0xcfadcd310a0203cbf904a80dfbb321147e812b19bad0e953e39982e2436d6ec9",
      "notes": "ETHDenver Sponsorship"
    }
@DefiDebauchery DefiDebauchery added the enhancement New feature or request label Sep 4, 2023
@DefiDebauchery DefiDebauchery changed the title Consider adding a dedicated "Notes" field to add context to transactions Consider adding a dedicated "Notes" field, adding context to transactions Sep 4, 2023
@frondoto
Copy link

frondoto commented Sep 5, 2023

👍

@iamjackgale
Copy link

Would be very helpful 👌

@Uxio0
Copy link
Member

Uxio0 commented Sep 29, 2023

Thanks for the suggestion @DefiDebauchery , we will analyze it as you are right, origin field has other meaning right now, so either we should standardize it or add a new property

@Uxio0 Uxio0 self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants