Hide GAP finiteness warnings during isomorphism check #38956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecks
GAP emits an "InfoWarning" message when it is checking for isomorphism
between two groups that are not known to be finite. This message is
only shown once, however, because after it checks for finiteness, it
knows. We have to keep this in mind during tests. For example,
File "src/sage/groups/finitely_presented_named.py", line 485, in
sage.groups.finitely_presented_named.AlternatingPresentation
Failed example:
A1.is_isomorphic(A2), A1.order()
Expected:
(True, 1)
Got:
#I Forcing finiteness test
(True, 1)
These warnings are "normal" and there's nothing for the user to do.
This commit hides them for the duration of the isomorphism check.
Fixes sagemath#38889
The warning "#I Forcing finiteness test" should no longer be emitted when checking for group isomorphism, so we remove it from the expected output in a few places. Fixes sagemath#38889
|
Documentation preview for this PR (built with commit 060f115; changes) is ready! 🎉 |
|
Thank you!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #38889 and others like it, we hide the
"#I Forcing finiteness testwarning that can be printed by GAP if one of the groups is not (yet) known to be finite.