New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session leaking resulting from random ISID use #329

Open

geek opened this issue May 29, 2020 · 0 comments

geek commented May 29, 2020 •

edited

Loading

According to https://tools.ietf.org/html/rfc3720#section-5.3.5 and https://tools.ietf.org/html/rfc3720#section-9.1.1 there should be some reuse of an ISID. The reuse is needed for situations like a timeout where libiscsi closes the connection and needs to reinstate the previous session, but indicate to the target that the old connection session is no longer valid.

The current behavior is that a reconnect will generate a random ISID.

As a result, any reconnect will cause a target to retain sessions that are no longer valid.

Let me know if you think this is a valid issue. Also, if you have any suggestions on how to fix I can try and help fix if needed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment