Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the workaround used in EntityManagerTest #193

Open
sai-pullabhotla opened this issue Feb 13, 2018 · 2 comments
Open

Remove the workaround used in EntityManagerTest #193

sai-pullabhotla opened this issue Feb 13, 2018 · 2 comments
Assignees

Comments

@sai-pullabhotla
Copy link
Owner

A couple of tests in EntityManagerTest were workedaround for the below issue. The latest version of DatastoreEmulator has fixed this issue, so we can remove the workaround.

DatastoreException - Error Code/Reason are inconsistent when working with Emulator #2442

@sai-pullabhotla
Copy link
Owner Author

Need to do this in DatastoreTransactionTest and DatastoreBatchTest as well.

@sai-pullabhotla
Copy link
Owner Author

Found that the builds are failing on Travis as Travis Builds use LocalDatastoreHelper for downloading and running the Emulator. The LocalDatastoreHelper is still downloading version 1.2.0 of the Emulator which still has this issue. Reported this to the google-cloud team. May have to revert the changes, unless the LocalDatastoreHelper is fixed soon.

@sai-pullabhotla sai-pullabhotla removed this from the 2.5.0 milestone Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant