Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest docker tag does not point to the latest version #303

Closed
cozyGalvinism opened this issue Nov 6, 2023 · 1 comment · Fixed by #302
Closed

Latest docker tag does not point to the latest version #303

cozyGalvinism opened this issue Nov 6, 2023 · 1 comment · Fixed by #302

Comments

@cozyGalvinism
Copy link

Since you changed your docker-compose.yml to use latest instead of a hardcoded version, the latest version that was built on GHA will be used, which in this case is 3.13 instead of 3.17.

image

This has already caused me 2 hours of tracing of what could've went wrong, because the latest dashboard version expects the latest Saleor version (some of the GraphQL queries expect fields that simply don't expect on older versions) and the latest tag not being the ACTUAL latest version is a huge issue.

@NyanKiyoshi
Copy link
Member

NyanKiyoshi commented Nov 6, 2023

Hi @cozyGalvinism, thank you for reporting this issue to us. It's been fixed for core at #302 (d975c34) and dashboard will be fixed in a follow-up pull request.

Edit: I was wrong for dashboard as I can see there is indeed a check for whether or not a release is latest: https://github.com/saleor/saleor-dashboard/blob/873954f2112a2eecbd5cd9b84fa720f68d257014/.github/workflows/publish-containers.yml#L32-L36

@NyanKiyoshi NyanKiyoshi linked a pull request Nov 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants