Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[language] Hardcoded key in InstallPreChecks.php #569

Open
likhobory opened this issue Nov 12, 2024 · 0 comments
Open

[language] Hardcoded key in InstallPreChecks.php #569

likhobory opened this issue Nov 12, 2024 · 0 comments
Labels
Area: Installation Issues & PRs related to the installation of the application Area: Language Issues & PRs that are confirmed as issues with language & translation within the core Priority:Moderate Issues & PRs that are minor; broken styling; warns; there are practical workarounds Severity: Minor Low Impact Type: Bug Something isn't working

Comments

@likhobory
Copy link

Issue

There is a hardcoded key $key = 'SERVER CHECKS';' instead of $key = $this->modStrings['LBL_SERVER_CHECKS']; in
https://github.com/salesagility/SuiteCRM-Core/blob/hotfix/core/backend/Install/Service/InstallPreChecks.php#L1136
Аs a result the translated pre-installation page looks like this:

image

Possible Fix

No response

Steps to Reproduce the Issue

see above

Context

No response

Version

8.7.1

What browser are you currently using?

Chrome

Browser Version

No response

Environment Information

PHP 8.2

Operating System and Version

Ubuntu 22

@likhobory likhobory added the Type: Bug Something isn't working label Nov 12, 2024
@johnM2401 johnM2401 added Priority:Moderate Issues & PRs that are minor; broken styling; warns; there are practical workarounds Area: Installation Issues & PRs related to the installation of the application Area: Language Issues & PRs that are confirmed as issues with language & translation within the core Severity: Minor Low Impact labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Installation Issues & PRs related to the installation of the application Area: Language Issues & PRs that are confirmed as issues with language & translation within the core Priority:Moderate Issues & PRs that are minor; broken styling; warns; there are practical workarounds Severity: Minor Low Impact Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants