-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix #10418 Global Search Labels fixed #10419
base: hotfix
Are you sure you want to change the base?
Conversation
Hello @lionfaris, thanks for your PR, could you please update the commit message to the following format: Fix Issue number - Commit message? For more information, visit our documentation: https://docs.suitecrm.com/community/contributing-code/bugs/ Thanks a lot in advance! Regards, |
@serhiisamko091184 Amended the commit message |
Hello @lionfaris, thanks for your quick reply and changes, would you be so kind to spend a little bit of your time and change the commit message to conform with the documentation? Thanks in advance! Regards, |
@serhiisamko091184 updated |
Many thanks, @lionfaris! |
Hi @lionfaris, Thank you for your PR. When re-reviewing I noticed the following: In tpls we commonly use Anyway, there is another PR that is fixing the same issue: Had you though of the solution on the PR above? I'm asking just to understand if there is any drawbacks on it that you might have found. |
When a user performs global search in the page that opens search button has empty label
After the fix
Description
Motivation and Context
How To Test This
Types of changes
Final checklist