Skip to content

Fix #10564 - Thank you message in Surveys only in English#10565

Merged
mattlorimer merged 1 commit intoSuiteCRM:hotfixfrom
SinergiaTIC:fix_10564
Mar 14, 2025
Merged

Fix #10564 - Thank you message in Surveys only in English#10565
mattlorimer merged 1 commit intoSuiteCRM:hotfixfrom
SinergiaTIC:fix_10564

Conversation

@SinergiaCRM
Copy link
Copy Markdown
Contributor

Description

Fixing #10564

Completing a survey redirects to a page where the message is only in English “Thanks for completing this survey”. The message should be displayed in the default language of the CRM.

Solution implemented:
The string have been implemented with the message that appeared at the beginning in English, therefore a variable has been created with the translate() function to collect these strings according to the language selected in the login.

Motivation and Context

Motivation: The message should be displayed in the default language of the instance.

How To Test This

  1. Go to Surveys and create a survey with a question.
  2. Send the survey and check that the message appears in the language selected in the login or the default language of the CRM.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Complexity Score given to PRs once assessed Area:Surveys Issues & PRs related to all things regarding Surveys labels Nov 1, 2024
@serhiisamko091184
Copy link
Copy Markdown
Contributor

Hello @SinergiaCRM!

Thanks for your contribution!

Regards,
Serhii

@jack7anderson7 jack7anderson7 added Status: Passed Testing Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review Status: Passed Testing labels Nov 7, 2024
@johnM2401 johnM2401 added Status: Ready to Merge PRs that have passed QA & can be merged into next release batch Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Dec 13, 2024
@mattlorimer mattlorimer merged commit f2d8e83 into SuiteCRM:hotfix Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area:Surveys Issues & PRs related to all things regarding Surveys Branch:Hotfix PR 4-8 Complexity Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing Status: Ready to Merge PRs that have passed QA & can be merged into next release batch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants