Skip to content

Commit b0df1b1

Browse files
author
Alexis Córdova
authored
fix(mobile): Update mobile documentation on various components (#4399)
1 parent d4f251a commit b0df1b1

File tree

13 files changed

+49
-57
lines changed

13 files changed

+49
-57
lines changed

Diff for: RELEASENOTES.general.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
<!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
22
<!-- On release, add general notes here. In time the legacy release notes will be add to this -->
33

4+
## 2.13.1 - August 26, 2020
5+
6+
- Added proper font-size change to mobile demos on the site
7+
48
## 2.13.0 - August 20, 2020
59

610
- Added opacity override for placeholder text in inputs for Firefox browser

Diff for: ui/components/buttons/RELEASENOTES.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88

99
### Fixed
1010

11-
- Added `background` shorthand and set to `initial` to recreated existing behavior that relied on the shorthand to apply initial values to unspecified values.
11+
- Added `background` shorthand and set to `initial` to recreate existing behavior that relied on the shorthand to apply initial values to unspecified values.
12+
- Fixed issue where mobile text size wasn't accurately sized.
1213

1314
## 2.13.0
1415

Diff for: ui/components/checkbox-button-group/RELEASENOTES.md

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.13.1
8+
9+
### Fixed
10+
11+
- Fixed issue where mobile text size wasn't accurately sized.
12+
713
## 2.11.5
814

915
### Added

Diff for: ui/components/form-element/RELEASENOTES.md

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.13.1
8+
9+
### Changed
10+
11+
- Removed Mobile example under Stacked Alignment and Horizontal Alignment examples, as they did not conform to the specification.
12+
713
## 2.13.0
814

915
### Changed

Diff for: ui/components/form-element/docs.mdx

-30
Original file line numberDiff line numberDiff line change
@@ -422,21 +422,6 @@ When you want the form elements inside of your record form to be stacked. Each `
422422
</CodeView>
423423
</Example>
424424

425-
<MobileNotice
426-
docsLink="#Mobile"
427-
header="Mobile context changes"
428-
elementName="form elements within a record form with stacked alignment"
429-
/>
430-
431-
<CodeView frameOnly>
432-
<RecordDetail
433-
snapshot={Snapshot.ObjectFieldTypes}
434-
isViewMode
435-
hasInlineEdit
436-
direction="stacked"
437-
/>
438-
</CodeView>
439-
440425
##### Horizontal Alignment
441426

442427
By adding the class `slds-form-element_horizontal` to every `slds-form-element`, your form can switch from stacked to left-aligned, horizontal labels in order to reduce vertical space.
@@ -452,21 +437,6 @@ By adding the class `slds-form-element_horizontal` to every `slds-form-element`,
452437
</CodeView>
453438
</Example>
454439

455-
<MobileNotice
456-
docsLink="#Mobile"
457-
header="Mobile context changes"
458-
elementName="form elements within a record form with horizontal alignment"
459-
/>
460-
461-
<CodeView frameOnly>
462-
<RecordDetail
463-
snapshot={Snapshot.ObjectFieldTypesHorizontal}
464-
isViewMode
465-
hasInlineEdit
466-
direction="horizontal"
467-
/>
468-
</CodeView>
469-
470440
#### Edit Mode
471441

472442
When a form switches to edit mode, we need to replace all readonly form elements with their semantic field type form element. The structure remains the same:

Diff for: ui/components/input/docs.mdx

+2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ on the icon, assistive technology reads out the content of the tooltip. If the t
3636

3737
In some cases, the read-only field state is swapped and has no `<input>`. This is called `static` in the examples. In that case, don’t use a `<label>`. This provides better accessibility for screen readers and keyboard navigators. Instead, use a `<span>` with the `.slds-form-element__label` class. Instead of an `<input>`, use the `.slds-form-element__static` class inside the `.slds-form-element__control` wrapper.
3838

39+
### Mobile
40+
3941
<MobileBlurb patternSpecificText="inputs will have an increased size to accommodate tapping with a finger instead of the more precise mouse cursor" />
4042

4143
<CodeView frameOnly>{InputExamples.default}</CodeView>

Diff for: ui/components/menus/RELEASENOTES.md

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.13.1
8+
9+
### Changed
10+
11+
- Removed Mobile examples as they did not conform to the specification.
12+
713
## 2.11.7
814

915
### Added

Diff for: ui/components/menus/docs.mdx

-9
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import * as DropdownHeight from '../menus/dropdown-height/example';
88
import { Submenu } from '../menus/submenu/example';
99
import { DoctypeIcon } from '../icons/doctype/example';
1010
import { getDisplayElementById } from '../../shared/helpers';
11-
import { MobileNotice, MobileBlurb } from '../../shared/doc-text';
1211

1312
<div className="doc lead">
1413
A Menu offers a list of actions or functions that a user can access.
@@ -43,14 +42,6 @@ The main thing that distinguishes menus from other popover blocks is keyboard na
4342
- Esc key closes the menu and moves focus back to the menu trigger
4443
- Any character key moves focus to the next menu item that starts with that character, if applicable
4544

46-
### Mobile
47-
48-
<MobileBlurb patternSpecificText="menus will have an increased button size to accommodate tapping with a finger instead of the more precise mouse cursor as well as larger text size" />
49-
50-
<CodeView frameOnly frameStyles={{ height: '14rem' }}>
51-
<IconLeft hasLeftIcon />
52-
</CodeView>
53-
5445
## Base
5546

5647
<Example title="Menu Base">

Diff for: ui/components/modals/RELEASENOTES.md

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.13.1
8+
9+
### Fixed
10+
11+
- Fixed issue where mobile text size wasn't accurately sized.
12+
713
## 2.13.0
814

915
### Added

Diff for: ui/components/popovers/RELEASENOTES.md

+7
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@
33
# Popovers Release Notes
44

55
<!-- ## [Unreleased] -->
6+
7+
## 2.13.1
8+
9+
### Changed
10+
11+
- Removed Mobile examples as they did not conform to the specification.
12+
613
## 2.12.0
714

815
### Fixed

Diff for: ui/components/popovers/docs.mdx

-17
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import * as FeatureExamples from './feature/example';
1212
import * as PreviewPanelExamples from './panels/example';
1313
import * as PromptExamples from './prompt/example';
1414
import { getDisplayElementById } from '../../shared/helpers';
15-
import { MobileNotice, MobileBlurb } from '../../shared/doc-text';
1615

1716
<div className="doc lead">
1817
A popover is a non-modal dialog. The component should be paired with a
@@ -50,14 +49,6 @@ Panel Popovers can be shown on mouse hover but for keyboard or screen reader use
5049
- If no Heading element is present, use the `aria-label` attribute and set the value to be a meaningful title of the `dialog`
5150
- The `dialog` should be described where possible. This can be achieved by applying the `aria-describedby` attribute to the `dialog` element and set the value to be the id of the Popover body
5251

53-
### Mobile
54-
55-
<MobileBlurb patternSpecificText="popovers will have increased close button size to accommodate tapping with a finger instead of the more precise mouse cursor" />
56-
57-
<CodeView frameOnly>
58-
{getDisplayElementById(NubbinExamples.states, 'bottom')}
59-
</CodeView>
60-
6152
## Base
6253

6354
<CodeView>{PopoverExamples.default}</CodeView>
@@ -290,14 +281,6 @@ Panel Popovers can be shown on mouse hover but for keyboard or screen reader use
290281

291282
<CodeView>{PromptExamples.default}</CodeView>
292283

293-
<MobileNotice
294-
docsLink="#Mobile"
295-
header="Mobile context changes"
296-
elementName="prompts"
297-
/>
298-
299-
<CodeView frameOnly>{PromptExamples.default}</CodeView>
300-
301284
#### Positioned top left
302285

303286
<CodeView demoStyles="height: 250px;">

Diff for: ui/components/radio-button-group/RELEASENOTES.md

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.13.1
8+
9+
### Fixed
10+
11+
- Fixed issue where mobile text size wasn't accurately sized.
12+
713
## 2.13.0
814

915
### Changed

Diff for: ui/touch-demo.scss

+4
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
@import 'init';
66
@import 'dependencies/touch';
77

8+
body {
9+
font-size: $font-size-5;
10+
}
11+
812
// Framework
913
@import 'components/touch';
1014
@import 'utilities/touch';

0 commit comments

Comments
 (0)